search

dgolja / golja-gnupg

Puppet module for managing GnuPG package and public keys
Apache License 2.0
13 stars 46 forks source link

Renewing Puppet Forge Approved Status #32

Open lionce opened 5 years ago

lionce commented 5 years ago

Hey dgolja,

Here at puppetlabs, we are currently going through all of our Approved modules on the Puppet Forge. We have some feedback for your module if you would be interested in retaining the approved status. If you are keen on keeping your approved status please ensure you respond as soon as you possibly can.

Many Thanks The Puppet Approvals Committee.

dgolja commented 5 years ago

I definitely have less time as I used to have, but if there are some reasonable changes I have to do to retain the approved status I am happy to do it.

lionce commented 5 years ago

Hello @dgolja,

Thank you for your prompt reply. In order for this module to remain approved, the following areas need to be updated: • Add Puppet 5+6 support • README should conform to documentation standards (see here) • Module should be under active maintenance (within last 6 months) Would be nice to update, but is not required: • Current build is failing (see here). Build’s reference is pointing to unknown build • Last update to the forge was on Jan 21st 2016, also the releases on github vs the forge seem inconsistent.

For additional information on Puppet Forge Approved criteria please see here.  Thank you for your cooperation. If you have any questions or concerns, don’t hesitate to let me know.

Cheers!

ekohl commented 3 years ago

Any update on this? Should it be migrated to Voxpupuli?

ekohl commented 1 year ago

@dgolja any update on this? The module is failing on Ruby 3.1 (and would on 3.0 too) due to URI.escape. I'd like to know if I should migrate/fork or can send PRs to update.

dgolja commented 1 year ago

If you can make an PR I will gladly merge it.

rbelnap commented 1 year ago

@dgolja any timeline for when the above PR can be accepted? I'd much rather use the module from the forge than a forked git repo. The PR seems straightforward, but I'm not ruby-savvy enough to detect any critical issues...

ekohl commented 1 year ago

A while back I started https://github.com/dgolja/golja-gnupg/pull/38 but I didn't have time to finish the acceptance test. However, it does do the majority of what's needed, including replacing Travis CI with GitHub Actions using the Vox Pupuli tooling.