search

dgolja / golja-gnupg

Puppet module for managing GnuPG package and public keys
Apache License 2.0
13 stars 46 forks source link

Replace deprecated URI.escape #37

Closed jplindquist closed 11 months ago

jplindquist commented 1 year ago

Trying to fix the following deprecation warnings running Puppet 7.x

/opt/puppetlabs/puppet/cache/lib/puppet/type/gnupg_key.rb:91: warning: URI.escape is obsolete
/opt/puppetlabs/puppet/cache/lib/puppet/type/gnupg_key.rb:102: warning: URI.escape is obsolete
/opt/puppetlabs/puppet/cache/lib/puppet/type/gnupg_key.rb:91: warning: URI.escape is obsolete
/opt/puppetlabs/puppet/cache/lib/puppet/type/gnupg_key.rb:102: warning: URI.escape is obsolete

I see that minimum supported version of Puppet listed is currently 3.0.0 which I believe supports Ruby 1.8.7 as a minimum. This should work with that if that's the case (trying not to rock the boat too much), but URI::DEFAULT_PARSER was introduced after Ruby > 1.9 roughly. Dealer's choice, or open to any other ideas. Thanks!

jplindquist commented 1 year ago

Related to #32 URI.escape issues mentioned as well

jplindquist commented 11 months ago

@dgolja Any chance for a review and/or release with this if all looks good? Thanks!

dgolja commented 11 months ago

LGTM tnx.

dhs-rec commented 3 months ago

@dgolja, any chance there will be a release in the near future? With Debian 12 shipping native Puppet agent packages, Puppet 7 and 8 running on Ruby 3.x has become a reality...