search

dgolja / golja-influxdb

Puppet module for InfluxDB
Apache License 2.0
19 stars 73 forks source link

typesdb is mandatory when collectd is enabled #18

Closed faxm0dem closed 8 years ago

faxm0dem commented 8 years ago

when enabling collectd but not providing typesdb influxdb fails to start with the following log:

[collectd] 2016/01/08 16:45:03 Starting collectd service
[copier] 2016/01/08 16:45:03 copier listener closed
[tcp] 2016/01/08 16:45:03 cluster service accept error: network connection closed
[snapshot] 2016/01/08 16:45:03 snapshot listener closed
[shard-precreation] 2016/01/08 16:45:03 Precreation service terminating
[continuous_querier] 2016/01/08 16:45:03 continuous query service terminating
[collectd] 2016/01/08 16:45:03 collectd UDP closed
[retention] 2016/01/08 16:45:03 retention policy enforcement terminating
[monitor] 2016/01/08 16:45:03 shutting down monitor system
[monitor] 2016/01/08 16:45:03 terminating storage of statistics
run: open server: open service: Open(): open : no such file or directory
dgolja commented 8 years ago

hey ... tnx for the commit. Let me review it and i will come back to you.

dgolja commented 8 years ago

so with the new "soon" to release module I redesigned how you manage collectd. Instead of using collectd_* params you will just pass a hash. Also with the new release I will switch to influxdb official repository, which means old influxdb versions won't be available anymore :(

In short if you use the module with older influxdb database please create an PR on the 2.2.X branch and I am happy to merge it and release 2.3.0, before releasing 3.0.0

faxm0dem commented 8 years ago

I don't understand. Branches master and 2.2.x are sync. Do you want me to resubmit this PR against 2.2.x instead?

dgolja commented 8 years ago

this is/will be fixed with the other changes.