search

dgolja / golja-influxdb

Puppet module for InfluxDB
Apache License 2.0
19 stars 73 forks source link

enables the possibility to specify a custom service provider #41

Open chillinger opened 7 years ago

chillinger commented 7 years ago

Useful for older versions of Puppet on systems with multiple init systems, where the default detected by puppet may not apply. This is true for Puppet < 4 and Debian > 8 for example.

Additionally, this behaviour is described in the documentation, but currently not implemented.

dgolja commented 7 years ago

hey tnx for the PR. Could you please fix the test errors ?

chillinger commented 7 years ago

oh, yes of course, I will.

------ Originalnachricht ------ Von: "Dejan Golja" notifications@github.com An: "n1tr0g/golja-influxdb" golja-influxdb@noreply.github.com Cc: "joesane" johannes.schillinger@gmail.com; "Author" author@noreply.github.com Gesendet: 11.07.2016 16:42:57 Betreff: Re: [n1tr0g/golja-influxdb] enables the possibility to specify a custom service provider (#41)

hey tnx for the PR. Could you please fix the test errors ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

chillinger commented 7 years ago

Hi, just ran the test suite after some trouble and only found those two errors:

Error: Invalid parameter api_port on Class[Influxdb::Server] at /tmp/apply_manifest.pp.Dh6TWA:1 on node ubuntu-trusty.synyx.

and

Error: Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type apt::source at /etc/puppet/modules/influxdb/manifests/repo/apt.pp:14 on node ubuntu-trusty.synyx.

None of whch seem to be related to my PR. Could you please have a look at this and clarify if the error is related or not?

Thanks and regards Johannes

Am 11.07.2016 um 16:42 schrieb Dejan Golja:

hey tnx for the PR. Could you please fix the test errors ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/n1tr0g/golja-influxdb/pull/41#issuecomment-231755443, or mute the thread https://github.com/notifications/unsubscribe/AFYj6IvV2ZB3cU1CmN9PuUedeK0XBJhdks5qUlZxgaJpZM4JJYCB.