dgolja / golja-influxdb

Puppet module for InfluxDB
Apache License 2.0
19 stars 73 forks source link

remove limitation on http max-row-limit #69

Open lukebigum opened 6 years ago

lukebigum commented 6 years ago

The default for HTTP max-row-limit is zero (see here). I think the module default should follow the software default (or better yet, not try set any options at all).

lukebigum commented 6 years ago

Oh, looks like there already is a PR for this - I should have checked first. I will be able to fix any broken tests though.

andyw-DH commented 6 years ago

+1 on this, setting max-row-limit enables response chunking, which breaks compatibility with grafana since at least 4.1.1. I am on grafana 5.0.3 and this issue is still present.

https://github.com/grafana/grafana/issues/7380