dgolja / golja-influxdb

Puppet module for InfluxDB
Apache License 2.0
19 stars 73 forks source link

Service influxdb does not refresh on config file change #71

Closed rcousens closed 6 years ago

rcousens commented 6 years ago

When supplying a collectd config as follows

  $collectd_config = {
    'default' => {
      'enabled'          => true, # not default
      'bind-address'     => ':25826',
      'database'         => 'collectd',
      'retention-policy' => '',
      'typesdb'          => '/usr/share/collectd/types.db',
      'batch-size'       => 5000,
      'batch-pending'    => 10,
      'batch-timeout'    => '10s',
      'read-buffer'      => 0,
    }
  }

  $global_config = {
    'reporting-disabled' => false,
  }

  class {'influxdb':
    manage_repos    => true,
    global_config => $global_config,
    collectd_config => $collectd_config,
  }

and using a systemd repo managed version of influxdb, the config is written after the package install which has already started the service. The config write should refresh the service so it will restart and pull in the new config. I will send a pull request momentarily, thank you!