dgolja / golja-influxdb

Puppet module for InfluxDB
Apache License 2.0
19 stars 73 forks source link

Topic/80 influxdb2 #81

Open freibuis opened 3 years ago

freibuis commented 3 years ago

this is an idea for ticket #80 to give influxdb2 support to this module.

some notes. will default to influxdb2 (if doing an upgrade rom v1 -> v2 I would suggest manually first.. )

for the life of me I could not get the tests to work before starting this. tried ruby 2.5.8, 2.7.2,3.0.0 to no avail!

freibuis commented 3 years ago

facts needs to be fixed

version 1

version_stdout = Facter::Util::Resolution.exec('influx --version')

version 2

version_stdout = Facter::Util::Resolution.exec('influx version')

just need to work out a chicken or the egg situation here.

how do I switch between the 2 without knowing what version in the first place? :thinking: maybe ill switch between the $package_name

freibuis commented 3 years ago

should params be split into defaults for v2/v1 :thinking: then include them based on the version?

 # sudo code
case $version { 
  1:          { include influxdb::params::defaults::1 }
  default: { include influxdb::params::defaults::2 }
}

each file contains the defaults for _config elements and options to drop elements like [admin] that no longer exist in v2