search

dgollahon / rspectre

Exorcise the apparitions haunting your tests.
MIT License
74 stars 9 forks source link

Remove deprecation warning #21

Closed srushe closed 5 years ago

srushe commented 6 years ago

Parser::Rewriter is deprecated, so we should update to Parser::TreeRewriter.

dgollahon commented 5 years ago

Thanks for the patch. :)

Looks like CI is stuck/busted (probably a result of the CircleCI 2.0 thing). :(

I haven't worked on this project in a while, but I'll hopefully get a chance to fix CI, merge your patch, and fix a few UX + other issues I've been meaning to get to soon.

bquorning commented 5 years ago

I'll hopefully get a chance to fix CI

See #22.

dgollahon commented 5 years ago

@srushe If you would be so kind as to rebase this branch, hopefully the retriggered CI should work correctly now (thanks to @bquorning and #22 🎉 ) and I can merge this.

srushe commented 5 years ago

Apologies for the delay, I completely missed the comment on rebasing. I've done it just now, but it looks like nothing was kicked off on CircleCI sadly.

dgollahon commented 5 years ago

@srushe No worries on the delay. :)

it looks like nothing was kicked off on CircleCI sadly.

That's so odd. Maybe it's still stuck from before somehow. I'm not sure why it won't run but I downloaded your branch and ran the tests locally so I'll just override the CI requirement.

Thanks for the fix.