Closed bquorning closed 1 year ago
cc @dgollahon
Hmm, I think some equality methods are missing from somewhere. When I make an rspectre run on a large code base, including the changes from this PR, I get a lot of let
s reported multiple times. It would be nice if we had some spec coverage to catch those cases.
Update: See second commit (04e747f5a5966fe83788fc5dd85ddce7a0394ac9)
The third commit (902afed22b87384ccb43cf5c1e0795512de6f380) should at least partially fix #46.
The important parts of this PR is really the 3rd and 4th commits (902afed22b87384ccb43cf5c1e0795512de6f380 and 80bc02eab52ecc7bf838bb175a8ef0047a762d96). Cleaning up gem dependencies and fixing CI are entirely unrelated things.
I can open a new PR with just those two commits, but CI would probably fail again. @dgollahon feel free to cherry-pick then and open a new PR.
Merged the specific part of your fix, will do a more complete follow up in a moment.
btw thanks for the PR @bquorning. I'm not sure how many people use this tool so I sometimes sort of forget about it but I like having a nudge to get back to it from time to time.
Of course! 👍🏼
This time I even got to dive a bit into your code and I almost understand how the proxy methods are set up 😅 All of your work on this tool is much appreciated.
Many of the gem dependencies seem to no longer be maintained.
This pull request removes the direct dependencies "anima" and "concord", and transitive dependencies "abstract_type", "adamantium", "equalizer", "memoizable", and "thread_safe".