Unnecessary '\n' character

dgorissen / coursera-dl

A script for downloading course material (video's, pdfs, quizzes, etc) from coursera.org

http://dirkgorissen.com/2012/09/07/coursera-dl-a-coursera-download-script/

GNU General Public License v3.0

1.74k stars 300 forks source link

Unnecessary '\n' character #1

Closed olegafx closed 11 years ago

olegafx commented 11 years ago

Completed quiz in video-lecture adds a "\nQuiz Attempted" label. It contains unnecessary '\n' character . '\n' produces fail in mkdir operation on Windows.

dgorissen commented 11 years ago

Added another check for this case as well as for non printable chars which may sneak through. If there are still issues now Ill switch to a whitelist approach. Let me know if it works for you.

olegafx commented 11 years ago

Yep, it works now. Thanks.

olegafx commented 11 years ago

I found that "Writing in the Sciences" course uses ' " ' symbol. List of illegal symbols in Windows file names: \ / : * ? " < > |

I think that you accidentally deleted " from source code, because I see it in diff :) 345

return re.sub('[:\?\/<>*"]', '', s).strip() 349
return re.sub('[:\?\/<>*\r\n]', '', s).strip()

dgorissen commented 11 years ago

noooooo! :) Switched to a whitelist, have another shot.