search

dgorissen / coursera-dl

A script for downloading course material (video's, pdfs, quizzes, etc) from coursera.org
http://dirkgorissen.com/2012/09/07/coursera-dl-a-coursera-download-script/
GNU General Public License v3.0
1.74k stars 300 forks source link

Option to exclude files from downloading #36

Closed ckotso closed 11 years ago

ckotso commented 11 years ago

Added -n command line option to exclude files from downloading, based on filename extension (e.g. srt, ppt).

dgorissen commented 11 years ago

Thanks for the patch, could you just elaborate on the usecase, I would image you typically would like to keep everything. Is it subtitles you are looking to skip?

ckotso commented 11 years ago

Yes, it's about the subtitles. Using VLC, one has to keep disabling subtitles for each clip once it starts playing -- or must globally disable auto-loading subtitles, which is also suboptimal. But someone else may not care about slides, notes, etc, so I assume it's not too bad to have the option.

dgorissen commented 11 years ago

mmm so the usecase is driven by the default behaviour of a particular media player which is a bit things on its head :) Note you can turn on/off subtitles in VLC by simply hitting the "v" key. Im not convinced there are many users for this feature (happy to be proven otherwise though) but then again it requires only small changes to the code. I will think about how it relates to issue #21 and then fix both together.

ckotso commented 11 years ago

Well, you are assuming that there is a keyboard to begin with :) But in fact I am viewing videos on my HTPC with either VLC or XBMC, using something like the MS Media Center Remote Control (no keyboard) to navigate. Switching subs on/off is a real pain, independent of the video player. Mapping some hardware key may be an option but other users may be uncomfortable with this...