search

dgorissen / pycel

A library for compiling excel spreadsheets to python code & visualizing them as a graph
GNU General Public License v3.0
570 stars 149 forks source link

Insufficient coverage and testing after recent merges #104

Closed andreif closed 3 years ago

andreif commented 4 years ago

https://github.com/dgorissen/pycel/pull/98 introduced insufficient coverage. Enabling free Travis CI for this repo would really help.

I had to make a few other fixes in order to make it through, see https://github.com/andreif/pycel/commit/511f9a10e870d25aa0615376e0d452e5a37a324f

stephenrauch commented 3 years ago

@dgorissen If have a few minutes to spare, could you hook this repo up to: https://travis-ci.com/ ?

dgorissen commented 3 years ago

Sure, let me have a look

dgorissen commented 3 years ago

Actually, I hooked up the repo but see that https://travis-ci.com/stephenrauch/pycel already exists. Is another one still need?

stephenrauch commented 3 years ago

@dgorissen My repo is also using travis, but only works against my repo. Your travis account however, appears to be hooked up, but is not working yet:

https://travis-ci.com/github/dgorissen/pycel/requests

Did you authorize a "plan" on travis? It seems it is sometimes needed to say OK, to the free plan.

https://travis-ci.com/account/plan

Also, could also hook up: https://codecov.io/ ?

dgorissen commented 3 years ago

Thanks @stephenrauch, facepalm. Travis should be working now, I was able to trigger a successful build. Codecov should also be hooked up (https://app.codecov.io/gh/dgorissen/pycel/). Let me know if anything else is needed.

stephenrauch commented 3 years ago

@dgorissen Everything looks great as can be seen on #107