dgorissen / pycel

A library for compiling excel spreadsheets to python code & visualizing them as a graph
GNU General Public License v3.0
573 stars 152 forks source link

`conditional_format_ids` to return a tuple instead of a list #85

Closed nanaposo closed 3 years ago

nanaposo commented 4 years ago

conditional_format_ids to return a tuple instead of a list. Tuple is the preferred choice when returning a collection.

I ran in into an issue where the result of the excel_formula.compiled_lambda() was used to check if it matched one of the return codes, however lists are not hashable. Converting to tuple fixed my issue https://github.com/dgorissen/pycel/blob/master/src/pycel/excelformula.py#L952