search

dgorski / app_tdd

TDD Module for Asterisk
3 stars 2 forks source link

app_tdd: Fix missing variables in TddStop. #21

Closed InterLinked1 closed 1 year ago

InterLinked1 commented 1 year ago

Fixes a minor issue with the new addition. With this, everything builds perfectly with Asterisk 20 and 21.

dgorski commented 1 year ago

I realized it is unneccesary as the detroy callback for the datastore should already do it; don't want two events. Was going to test when I relized this was redundant, but got sidetracked before I pulled it back out.

InterLinked1 commented 1 year ago

I realized it is unneccesary as the detroy callback for the datastore should already do it; don't want two events. Was going to test when I relized this was redundant, but got sidetracked before I pulled it back out.

Can you explain how it's unnecessary exactly? The variables aren't defined at all in that function. As such, it doesn't compile without this change.

Edit: Ah, I see, you just removed that code altogether - that works too!