dgp1130 / rules_prerender

A Bazel rule set for prerending HTML pages.
13 stars 0 forks source link

`strict_visibility = True` compatibility #15

Open dgp1130 opened 3 years ago

dgp1130 commented 3 years ago

Currently, rules_prerender does not work with workspaces that have strict_visiliby = True (which is the default). This is because we expose Bazel macros that load our own dependencies which may not be listed as dependencies in the user workspace and thus may not be visible.

I filed an issue to rules_nodejs for guidance around this restriction as I'm not sure what to do about it. There are a couple possible workarounds but come with their own limitations, and this seems like more of a design flaw in strict_visibility rather than anything rules_prerender is necessarily doing wrong.