search

dgp1130 / rules_prerender

A Bazel rule set for prerending HTML pages.
13 stars 0 forks source link

Add `tsconfig` option to `prerender_*()` #21

Closed dgp1130 closed 3 years ago

dgp1130 commented 3 years ago

Right now, all the ts_library() rules being generated do not specify a tsconfig, so I believe they default to //:tsconfig.json. This happens to work in rules_prerender because that is where the tsconfig is, but user repository may not follow that convention. We should give users a hook to provide their own tsconfig.

dgp1130 commented 3 years ago

Fixed by https://github.com/dgp1130/rules_prerender/commit/6b47d6d27831288d3108e6381bc774adc48149a7 and https://github.com/dgp1130/rules_prerender/commit/7327a03e365d194a7c773bdd7abdaf37e2afea83 (forgot to add Fixes note to the commit message).