dgp1130 / rules_prerender

A Bazel rule set for prerending HTML pages.
14 stars 0 forks source link

Verify NPM package versions #57

Open dgp1130 opened 1 year ago

dgp1130 commented 1 year ago

We should generate a test which asserts that the rules_prerender and @rules_prerender/* NPM packages are the same version as the @rules_prerender workspace to avoid version skew.

This is tricky to do in practice, since currently there is nothing in the repository source which actually specifies the version number. I've tried to keep it that way because manual version bumps just introduce a lot of toil. I'm not entirely sure how to do this without manually managing versions, but one idea I have is:

This means that the released workspace doesn't 1:1 match the actual workspace source, but that might be a small enough difference to not matter? If you're depending on it through other means (such as a local checkout of the source installed via local_repository()), then I think it's fair to skip/not support this verification.