Closed dgp1130 closed 2 years ago
When I wasn't looking rules_nodejs
upgraded to 5.0.0+, so I don't thinking supporting v2 is a major issue. Once rules_prerender
gets closer to a 1.0.0 release I can reevaluate the lower bound of dependencies to support.
rules_nodejs
v3 only came out a couple weeks ago, we should try to support v2 for older workspaces who might want to try this out.Since this project is still experimental, this support isn't super-necessary, but is nice to have. We started as v2, so we should be fairly compatible. The biggest challenge is how to handle
ts_devserver()
, which got renamed toconcatjs_devserver()
in v3. Unfortunately,ts_devserver()
does not exist in v3 andconcatjs_devserver()
does not exist in v2, so there is no name we can use that will consistently work. I'm also not aware of a way to conditionally load a dependency Starlark file, so I don't see a way to resolve that discrepancy. Will need a little more research to understand the best way of fixing this.