search

dgraham / eslint-plugin-jquery

Disallow jQuery functions with native equivalents.
MIT License
209 stars 22 forks source link

v1.5.0 is a breaking change #32

Open ljharb opened 5 years ago

ljharb commented 5 years ago

https://github.com/dgraham/eslint-plugin-jquery/commit/718e25649d5baf42d8a5a447d4ba58d1d21af6ce#diff-b9cfc7f2cdf78a7f4b91a753d10865a2 is a breaking change, since all peer deps are part of your public API. This broke our builds.

Please release v1.5.1 with that commit reverted, and then if you'd like you're welcome to rerelease it as v2 :-)

ljharb commented 5 years ago

(this also implies that #20 was a breaking change - which it was - so that'll need to be reverted too in a v1.5.1)

macklinu commented 5 years ago

Sorry about not calling out the possibility of a breaking change in #20 - was an oversight at the time.

@dgraham let me know if I can help with anything here. 😃

diegocr commented 2 years ago

What about ESLint 8.x ?