dgraph-io / badger

Fast key-value DB in Go.
https://dgraph.io/badger
Apache License 2.0
13.7k stars 1.17k forks source link

[FEATURE]: Storing values larger than 2 GB #2040

Open mitar opened 7 months ago

mitar commented 7 months ago

Have you tried Badger before this proposal? and did not find anything similar?

None

What you wanted to do.

I wanted to set ValueLogFileSize to 6 GB.

What you actually did.

Called opts.WithValueLogFileSize(6 * 1024 * 1024 * 1024).

Why wasn't it great, with examples.

I got error Invalid ValueLogFileSize, must be in range [1MB, 2GB).

Additional information.

Could this limit be lifted on 64bit systems? It seems to me that this is just to support mmap on 32 bit systems and there is really no design limitation why not to support larger values? On my system, I have:

$ grep -m1 "address sizes" /proc/cpuinfo 
address sizes   : 39 bits physical, 48 bits virtual

So a bit less than 2^47 (128 TiB) could be the max limit for mmap on my system.

simon28082 commented 7 months ago

I have the same problem, 2G is too little for me, we need more than 8G

nathanhack commented 7 months ago

Same here

github-actions[bot] commented 1 month ago

This issue has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

mitar commented 1 month ago

Still relevant.