search

dgraph-io / dgraph-docs

A native GraphQL Database with a graph backend
https://dgraph.io/docs
Other
35 stars 66 forks source link

Typo in DGraph Cloud Schema editor when deleting a predicate #629

Closed nick-w-nick closed 1 year ago

nick-w-nick commented 1 year ago

This may or may not be the right place to post this issue, but since the DGraph Cloud UI itself is not open source, this seemed like the right place as the docs are partially related to DGraph Cloud. Let me know if this issue should be created elsewhere instead.

I noticed when trying to delete a predicate on the DQL Schema tab on the Schema page in DGraph Cloud that the text that is shown in the confirmation modal has a typo. permenetly should be permanently.

dgraph-cloud-delete-predicate-typo

I also think the text "The type will be permanently removed" is a bit misleading and should instead say "The predicate will be permanently removed". You can't outright delete a type from the UI in this way, so it's not like the modal is re-used for both operations.

This issue is specifically to raise notice regarding the typo but just thought I'd make a suggestion regarding the wording while in this area as well.

Thanks!

MichelDiz commented 1 year ago

Thank you @nick-w-nick, I have fixed internally. Just wait for the redeployment.

Cheers!

nick-w-nick commented 10 months ago

@MichelDiz FYI, I can't recall if I ever verified if the issue was fully fixed after your reply, so I am not sure if it is a regression or not, but the issue does still seem to be present in the DGraph Cloud UI when deleting a predicate.

dgraph-delete-predicate-typo

MichelDiz commented 10 months ago

@nick-w-nick I'm not working at Dgraph anymore. Maybe @rderbier or @damonfeldman can help you with this on the cloud product.