Closed adg closed 5 years ago
Hey @adg where do you see that Dgraph is going to support modules? :)
@adg check my comment here https://github.com/dgraph-io/dgraph/pull/4146#issuecomment-540828071
Still getting the same error as before they added go module support. Any ideas? :P
If you saw the same error before and after modules were added, then I don't think it's related to this issue.
@danielmai do you know how to go about fixing this? I am guessing we could have a dgraph-root argument the same way we do for the jepsen test binary.
Something like dgraph-root that refers to the root of the repo would work. The tests and the test scripts should no longer assume that Dgraph or anything other repos (like the benchmarks repo for data files) are in GOPATH.
Closing since the issue it's been addressed
Now that the project is being made to support modules, there are still some old GOPATH-isms that remain. In
test.sh
and some of the included scripts, there are assumptions that the repo will be checked out into$GOPATH/src/github.com/dgraph-io/dgraph
, when with modules it may be checked out anywhere.