dgraph-io / ristretto

A high performance memory-bound Go cache
https://dgraph.io/blog/post/introducing-ristretto-high-perf-go-cache/
Apache License 2.0
5.54k stars 364 forks source link

fix: cleanupTicker not being stopped #343

Closed IlyaFloppy closed 1 year ago

IlyaFloppy commented 1 year ago

Problem

cleanupTickerthat is created in NewCache is never stopped, which is why the code below causes a memory leak

for {
    c, _ := NewCache(...)
    c.Close()
}

Solution

Stop cleanupTicker in Close method.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ilya Popovnin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.