search

dgraph-io / ristretto

A high performance memory-bound Go cache
https://dgraph.io/blog/post/introducing-ristretto-high-perf-go-cache/
Apache License 2.0
5.54k stars 364 forks source link

remove glog dependency #350

Closed jhawk28 closed 1 year ago

jhawk28 commented 1 year ago

updated go mod deps

glog adds global flags so it is not a good library (adding to an existing program causes a panic if a flag name conflicts)

mholt commented 1 year ago

Thank you for making this :pray:

mangalaman93 commented 1 year ago

Thanks for updating the PR. Merged.

jackcipher commented 1 year ago

Hi maintainers,

I noticed that pull request #350 was merged yesterday, but a new tag has not been released yet.Without a new tag, I can't update my go mod.Would you please release a new tag?

mholt commented 1 year ago

@jackcipher FYI you can always do go get <module>@<commit> even if there is not a tag yet :blush: