Fix some memory leaks in TTL implementation

dgraph-io / ristretto

A high performance memory-bound Go cache

https://dgraph.io/blog/post/introducing-ristretto-high-perf-go-cache/

Apache License 2.0

5.54k stars 364 forks source link

Fix some memory leaks in TTL implementation #358

Closed Woutifier closed 1 month ago

Woutifier commented 11 months ago

The aim of this PR is to resolve three issues with the Ristretto TTL implementation:

Expiry cleanup is not guaranteed to run, if it doesn't run when expected memory is leaked
expiryMap isn't cleared when cache is cleared
on Update items are added into the expiryMap even if they have no TTL set

CLAassistant commented 11 months ago

All committers have signed the CLA.

CLAassistant commented 11 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-actions[bot] commented 2 months ago

This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

Woutifier commented 2 months ago

Still relevant.

Should this project be archived, or marked as deprecated? These are serious issues that have gone unaddressed for a very long time.

mangalaman93 commented 1 month ago

Hi @Woutifier, Thanks for the PR and apologies for the delay. I am reviewing this PR on priority. Meanwhile, if you get a chance, feel free to merge/rebase with/on main.

Woutifier commented 1 month ago

Thanks for taking this PR into consideration :-). Let me know if there's anything I can do to help