Closed pete-woods closed 8 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thanks for the PR. The only problem that I see with this is that any new type addition requires changes to the code and upgrading ristretto.
Thanks for the PR. The only problem that I see with this is that any new type addition requires changes to the code and upgrading ristretto.
I believe this is already the case (see linked code): https://github.com/dgraph-io/ristretto/blob/main/z/z.go#L55
Also I put the type next to the key mapping func, so it's clear they both need updating in lockstep.
Thanks for your time! 🙇
Without this, you can specify key types that aren't supported and then have to deal with panics, rather than more pleasant compile-time warnings.