search

dgraph-io / ristretto

A high performance memory-bound Go cache
https://dgraph.io/blog/post/introducing-ristretto-high-perf-go-cache/
Apache License 2.0
5.54k stars 364 forks source link

Missing commits/PRs on main #377

Closed stlava closed 1 month ago

stlava commented 5 months ago

Question.

I found that a few PRs made back in 2022 were merged into master instead of main and now the two histories (and versions) differ. I didn't piece the timeline together but what I assume happened was a few PRs were opened against master and the repo changed default branches.

Specifically a race condition fixed in https://github.com/dgraph-io/ristretto/pull/294 got merged into master and never made it to main.

The way I found this was a project I'm working on uses v0.0.0-20220403145359-8e850b710d6d and I had trouble finding that hash version until it occurred to check the master branch which may have been default at the time.

github-actions[bot] commented 2 months ago

This issue has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

StarpTech commented 2 months ago

Hi, any updates? We run into the same race condition and it would be very sad if we wouldn't find one to cherry pick the contributions.