search

dgrapov / CTSgetR

R interface to Chemical Translation Service (CTS)
14 stars 9 forks source link

Fixed post dependency definitions #2

Open stanstrup opened 8 years ago

stanstrup commented 8 years ago

The functions 'translate.index' and 'IDEOMgetR' seem not to be defined anywhere and I don't know if they are from some other package.

CTSgetR has different parameters in the code and man page. There are a number of other build check errors still left.

dgrapov commented 8 years ago

I've pushed a recently tested version. See the branch simple. It seems to work?

Thanks! -Dmitry

dgrapov commented 8 years ago

Hi,

Thank you for the pull request, can you please take a look at the simple branch to see if your original issue is fixed?

I took some more time and rewrote the package using httr which greatly simplified everything. I am using GET; where did you need a POST?

-Dmitry

stanstrup commented 8 years ago

Hi. I checked it now. Dependencies are still not defined in the DESCRIPTION file. You should probably add the used packages as "imports".

The check fails with this error so I don't know if there are more problems:

checking package dependencies ... ERROR
Namespace dependencies not required: 'httr' 'jsonlite'
dgrapov commented 8 years ago

Ok, now check is passing. If you need any of the older functionality feel free to add; I will accept pulls :smile: .

Thanks.

-Dmitry

dgrapov commented 8 years ago

Note one of the test is failing, but I also noticed CTS has variability for failures, so I am ignoring this. Could remove test if need be.