search

dgreene1 / react-accessible-treeview

A react component that implements the treeview pattern as described by the WAI-ARIA Authoring Practices.
https://dgreene1.github.io/react-accessible-treeview
MIT License
277 stars 37 forks source link

Add boolean support. Fixes #164 #167

Closed blittle closed 10 months ago

blittle commented 10 months ago

This adds support for booleans in the node metadata. This change will make it easier for a use-case we have at Shopify. Initially I ran prettier on the project, but noticed that the lint-staged config seems to be broken, because both files had lots of changes after running prettier. If you'd like, I can add a separate commit to auto format the code.

closes #164

dgreene1 commented 10 months ago

Thank you @blittle for your contribution. @mellis481 or @yhy-1 can you publish this change?

blittle commented 10 months ago

It doesn't look like the recent 2.8.1 release included this change?

https://unpkg.com/browse/react-accessible-treeview@2.8.1/dist/TreeView/utils.d.ts#:~:text=export%20type%20IFlatMetadata

dgreene1 commented 10 months ago

@yhy-1 do you know? And if it wasn’t, can we do a release (pending Kevin being okay with us doing that this sprint). Cc @mellis481

yhy-1 commented 9 months ago

@blittle @dgreene1 v2.8.1 was published before this PR was merged in. Please refer to the release note https://github.com/dgreene1/react-accessible-treeview/releases/tag/v2.8.1.

I was having a little trouble publishing last time for v2.8.2. It should be released now.

blittle commented 9 months ago

Sweet @yhy-1 thank you!