search

dgreene1 / react-accessible-treeview

A react component that implements the treeview pattern as described by the WAI-ARIA Authoring Practices.
https://dgreene1.github.io/react-accessible-treeview
MIT License
277 stars 37 forks source link

Add SelectedIds props for controlled selection #45

Closed kpustakhod closed 2 years ago

kpustakhod commented 2 years ago

Recreate closed PR https://github.com/dgreene1/react-accessible-treeview/pull/37

dgreene1 commented 2 years ago

@mellis481 i don’t have a lot of context for this. Can you review it? Also @kpustakhod please link to a Github issue so future readers understand why this change was made.

mellis481 commented 2 years ago

@dgreene1 Sure. @kpustakhod had previously created what is included in this PR in our @vertexinc version of react-accessible-treeview. That PR got merged. To keep the dgreene1/react-accessible-treeview in sync, she created this PR, but it got automatically closed when the repo was transferred from lissitz before it could get merged. So this is functionality that is needed and functionality that the DS is currently using (in the @vertexinc version of react-accessible-treeview). It's good to merge.