search

dgreif / homebridge-hatch-baby-rest

A homebridge plugin for Hatch Baby Rest night light
MIT License
74 stars 19 forks source link

config option to only include the BaseAcessory (master on/off switch) #58

Closed steveredden closed 3 years ago

steveredden commented 3 years ago

Can you add a checkbox for not deploying the additional accessories? I've only found use of the master switch so far.

config.schema.json

"includeExtraAccessories": {
  "title": "Include Extra Accessories",
  "type": "boolean",
  "description": "Include Soundtrack Fan, Volume, and Light Accessories (where applicable)",
  "placeholder": "zInclude Extra Accessories",
  "default": "true",
  "oneOf": [
    { "title": "Yes", "enum": ["true"] },
    { "title": "No", "enum": ["false"] }
  ],
  "required": false
},

image

was planning a PR but wasn't sure where to implement in platform.ts - maybe lines 105:115?

Or maybe you could help me customize out the extra accessories?

dgreif commented 3 years ago

This is a duplicate of #53. I don't see much value in adding extra configuration just to remove accessories in this case.

steveredden commented 3 years ago

How about at least polling for the master’s state and turn off the light/fan/volume? It’s “odd” to see these constantly “on.”

that’s the main reason I find them annoying.

Or just implement the twice-asked request :P