dgreif / ring

Unofficial packages for Ring Doorbells, Cameras, Alarm System, and Smart Lighting
MIT License
1.2k stars 161 forks source link

Device Name Not Updated #1267

Closed mikedbenton closed 1 year ago

mikedbenton commented 1 year ago

Is there an existing issue for this?

Describe The Bug

I added 6 smoke detectors to Ring which created 12 devices - a smoke detector device and a CO detector device for each. They were all given the same name in Ring, and subsequently given the same name in Home for the CO device and a generic name for the Smoke devices.

I have since gone back into Ring and updated each of the devices to reflect a more descriptive name for each. I have rebooted the Ring base station, the ring plug-in, the Homebridge server. Regardless, the original names persist in Home. When viewing the Status window, I see the original names and not the updated names.

To Reproduce

No response

Expected behavior

I expect Home to be updated with the newly assigned names. I also expect the updated name to be reflected when the device inventory is displayed with the plug-in initializes.

Relevant log output

[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory e23746ff-5c3c-477f-a3a4-bcc320fa9ee9 Smoke & CO Alarm 50915
[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory 2ea353e7-128f-4eba-8d68-ea8e0b91afdc First Alert CO Alarm
[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory 4273787f-5cda-4c87-8264-278c71f8e296 Smoke & CO Alarm 28872
[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory 2dd62ff9-eca2-4649-bfa9-ec0157437b4f First Alert CO Alarm
[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory f7df1175-ca55-4da8-b840-327ae3d051a9 Smoke & CO Alarm 08707
[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory 65c1be04-c26f-496f-8fd5-67d36b6be27d First Alert CO Alarm
[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory e43f77c8-cdf3-4916-82f5-7d14e2252c95 Smoke & CO Alarm 63560
[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory 4d73c2c8-5b91-48cf-a55f-00e71d81d84f First Alert CO Alarm
[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory ae89e278-be21-4959-83af-e99c12e53e3b Smoke & CO Alarm 46982
[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory 3a85f5b5-33a1-471f-b006-6103dddf051a First Alert CO Alarm
[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory 1dd1622b-e7a7-4a40-88e1-1505f3f24f54 Smoke & CO Alarm 47490
[19/07/2023, 09:34:41] [homebridge-ring] Configuring cached accessory e2059dee-b741-4ad3-a675-f3c15ff97012 First Alert CO Alarm

Screenshots

IMG_5074

Homebridge Ring Config

Using vanilla implementation, no customization.

Additional context

No response

OS

Raspbian

Node.js Version

v18.16.0

NPM Version

Not Sure - Likely the latest

Homebridge/HOOBs Version

v1.6.1

Homebridge Ring Plugin Version

v11.8.0

Operating System

Raspbian

dgreif commented 1 year ago

Hey @mikedbenton, sorry the rename didn't carry over. It's been a long while since I looked into this, but from what I remember the name is cached on the HomeKit side once the accessory is created. Even if you change it via the homebridge API, HomeKit holds on to the original name. I think this is because you can change the name on the HomeKit side, and they don't want homebridge overwriting your changes every time you restart the server. Unfortunately I don't think there is a workaround for this issue, other than removing these devices and re-adding them. If you want to go that route, the easiest thing would be to add a hideDeviceIds field to your config and give it all the IDs from the logs you provided above (e.g. "hideDeviceIds": ["e23746ff-5c3c-477f-a3a4-bcc320fa9ee9", "OTHER IDS HERE"]). Once you add those, restart homebridge to remove them from HomeKit, then remove that config and restart homebridge again to add them back.