search

dgreif / ring

Unofficial packages for Ring Doorbells, Cameras, Alarm System, and Smart Lighting
MIT License
1.21k stars 163 forks source link

ffmpeg: Expose stdout callback to user #1386

Closed kkuehlz closed 8 months ago

kkuehlz commented 8 months ago

Integrating in https://github.com/homebridge/camera-utils/pull/584

Would appreciate if we could do a new release once this is merged so I can use in my application.

kkuehlz commented 8 months ago

cc @dgreif

Don't have permission to request reviewers

dgreif commented 8 months ago

@keur I'll go ahead and merge this, but I'm not sure we need to do a release just for this bump. Since we allow patch/minor updates for the @homebridge/camera-utils package, you should be able to install the latest version of that package and have ring automatically start using it.

kkuehlz commented 8 months ago

@dgreif Thank you!

The way I call startTranscoding() has changed with this new callback option. I understand if you don't want to do a release for such a tiny API change. I'm fine pointing the package at git+https://github/dgreif/ring#main. In fact, I am doing that right now to point at my fork. However, I am including it from a JS project. That means I need to go into node_modules and manually build the ring-client-api package, then include the lib directory. My final include ends up looking like this: const { RingApi } = require('ring/packages/ring-client-api/lib')

It gets a little ugly. Is there a better way to do that? I don't program JS regularly, so apologies if these are basic questions.

EDIT: Nevermind. I just published the package to npm under my own username. So I have a workaround.