search

dgreif / ring

Unofficial packages for Ring Doorbells, Cameras, Alarm System, and Smart Lighting
MIT License
1.17k stars 157 forks source link

sendDoorbellMotionNotificationsToTv? #469

Closed fancypants66 closed 3 years ago

fancypants66 commented 3 years ago

Feature Request

Description

Really loving the new ability to "sendCameraMotionNotificationsToTv" feature for non-doorbell cameras -- but anyway to accomplish the same result for doorbell motion events? I think this would require triggering a "virtual ring" on a doorbell motion event.

Describe the solution you'd like

Most delivery people don't ring my doorbell, however I'd like to be notified on Apple TV when there is a motion event or ring at my doorbell. Same feature as "sendCameraMotionNotificationsToTv" for non-doorbell accessories, but this one for doorbell motion, hence "sendDoorbellMotionNotificationsToTv" ;)

Describe alternatives you've considered

I was trying to see if there was a way to trigger a virtual ring when motion is detected at the doorbell, but I don't believe a ring trigger event is exposed.

dgreif commented 3 years ago

Released sendDoorbellMotionNotificationsToTv in v9.11.0. Give it a try and let me know how it works for you

shaileshck commented 3 years ago

Hi,

Is that this would activate camera view on Apple TV even if there is motion detected?

shaileshck commented 3 years ago

Hi,

Is that this would activate camera view on Apple TV even if there is motion detected?

Great it works..

shaileshck commented 3 years ago

Hi, Is that this would activate camera view on Apple TV even if there is motion detected?

Great it works..

Feedback... Motion alerts are shown as Door Bell Rang... on Phone notifications...

shaileshck commented 3 years ago

Observing Restart of Homebridge issue.. Sharing logs.

[10/13/2020, 2:58:08 PM] [Ring] Front Door Detected Motion. Loading snapshot before sending event to HomeKit [10/13/2020, 2:58:08 PM] [Ring] Front Door Motion Detected - Simulating Doorbell Press. Loading snapshot before sending event to HomeKit [10/13/2020, 2:58:09 PM] [Ring] Preparing Live Stream for Front Door [10/13/2020, 2:58:09 PM] [Ring] Stream Prepared for Front Door (0.23s) [10/13/2020, 2:58:09 PM] [Ring] Received stream data from Front Door (0.268s) [10/13/2020, 2:58:09 PM] [Ring] From Ring (Front Door): exited with code 1 and signal null [10/13/2020, 2:58:09 PM] [Ring] Streaming active for Front Door Error: SIP request made after call was destroyed at SipCall.request (/usr/local/lib/node_modules/homebridge-ring/lib/api/sip-call.js:113:35) at SipCall.sendKeyFrameRequest (/usr/local/lib/node_modules/homebridge-ring/lib/api/sip-call.js:184:21) at SipCall. (/usr/local/lib/node_modules/homebridge-ring/lib/api/sip-call.js:212:24) at Generator.next () at fulfilled (/usr/local/lib/node_modules/homebridge-ring/lib/api/sip-call.js:5:58) Error: SIP request made after call was destroyed at SipCall.request (/usr/local/lib/node_modules/homebridge-ring/lib/api/sip-call.js:113:35) at SipCall.sendKeyFrameRequest (/usr/local/lib/node_modules/homebridge-ring/lib/api/sip-call.js:184:21) at SipCall. (/usr/local/lib/node_modules/homebridge-ring/lib/api/sip-call.js:212:24) at Generator.next () at fulfilled (/usr/local/lib/node_modules/homebridge-ring/lib/api/sip-call.js:5:58) [10/13/2020, 2:58:12 PM] Got SIGTERM, shutting down Homebridge... [10/13/2020, 2:58:12 PM] [Apple TV Platform] Shutting down Apple TV clients... [10/13/2020, 2:58:13 PM] [Ring] Front Door Doorbell Pressed. Loading snapshot before sending event to HomeKit [10/13/2020, 2:58:13 PM] [Ring] Snapshot for Front Door is still within its life time (4.557s old) [10/13/2020, 2:58:17 PM] [HB Supervisor] Homebridge Process Ended. Code: 143, Signal: null [10/13/2020, 2:58:22 PM] [HB Supervisor] Restarting Homebridge... [10/13/2020, 2:58:22 PM] [HB Supervisor] Starting Homebridge with extra flags: -I [10/13/2020, 2:58:22 PM] [HB Supervisor] Started Homebridge v1.2.3 with PID: 64572

fancypants66 commented 3 years ago

@dgreif Thank you for this!! sendDoorbellMotionNotificationsToTv feature is working for me as described on tvOS 14. @shaileshck on iOS 14.0.1/homebridge 1.2.3/homebridge-ring v9.11.0 - doorbell motion alerts are coming in correctly for me as "doorbell camera has detected motion" - no errors in logs. Hope this helps.

shaileshck commented 3 years ago

@fancypants66 Thanks.. It does work for me.. Logs shared are for frequent crashes seen in homebridge. Attached logs for the same.

paqpaqpaq commented 3 years ago

It works, however, it IS a ring trigger. On iPhone ,14.2 beta 3, I receive two notifications simultaneously. 1 motion, 1 doorbell trigger.

The TV shows the video in a pane.

However, because of the doorbell trigger, also my homepod rings. So now I am now sure if the person actually rang the door, or just passed by. Quite confusing.

dgreif commented 3 years ago

@paqpaqpaq @shaileshck that's the only way to get the notification to automatically open on tvOS 14. You are welcome to disable the option if you aren't happy with the behavior. This is a HomeKit/tvOS limitation and the option is here if you are ok with the side-effects.

@fancypants66 thanks for confirming it works!

shaileshck commented 3 years ago

On 17-Oct-2020, at 12:57 AM, Dusty Greif notifications@github.com wrote:

@paqpaqpaq https://github.com/paqpaqpaq @shaileshck https://github.com/shaileshck that's the only way to get the notification to automatically open on tvOS 14. You are welcome to disable the option if you aren't happy with the behavior. This is a HomeKit/tvOS limitation and the option is here if you are ok with the side-effects.

@fancypants66 https://github.com/fancypants66 thanks for confirming it works!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dgreif/ring/issues/469#issuecomment-710476752, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFLWWANMRACKW2D76A3PL3SLCNDTANCNFSM4SEDNSSQ.

@Dusty

Appreciate your solution which could best work around the achieve notification video on TVOS.

I would love if the same works well on MACOS as well as on MACOS HOMEKIT the video doesn’t play at all. its just goes round and round to fetch the video and the not responding message comes.

Also home bridge seems to crash which and reboot.. logs shared to this note earlier. Rest its perfect. Its a feedback. Suppose the one you would like to hear and make required changes to stabilise the same.

PFA

Regards

Shailesh K.

shaileshck commented 3 years ago

Hi Dusty,

Appreciate your good work on Ring Homekit support with Homebridge.

Have configured my Homebridge with the latest plugin and following config.

I had two questions for you.

1) Can we increase the time the video is displayed on Apple TV when notification comes. 2) Using currently Homebridge on Mac, Would like to make permanent setup using some Raspberry Pi. Pls suggest which will be best model recommended suitable to use for Ring videos as heard on some blogs all models not supported or video would lag. Pls suggest.

Regards

Shailesh K.

shaileshck commented 3 years ago

Missed adding current config. Pls suggest any optimisations.

{ "refreshToken": "sendCameraMotionNotificationsToTv": true, "sendDoorbellMotionNotificationsToTv": true, "cameraStatusPollingSeconds": 10, "cameraDingsPollingSeconds": 2, "debug": false, "platform": "Ring" }

On 19-Oct-2020, at 5:46 PM, Shailesh Kanolkar shaileshck@gmail.com wrote:

Hi Dusty,

Appreciate your good work on Ring Homekit support with Homebridge.

Have configured my Homebridge with the latest plugin and following config.

I had two questions for you.

1) Can we increase the time the video is displayed on Apple TV when notification comes. 2) Using currently Homebridge on Mac, Would like to make permanent setup using some Raspberry Pi. Pls suggest which will be best model recommended suitable to use for Ring videos as heard on some blogs all models not supported or video would lag. Pls suggest.

Regards

Shailesh K.

SlasherKG commented 3 years ago

@shaileshck you need to remove that Ring token from your post quick. Someone can gain access to all your devices.

Actually, it's probably too late and I wouldn't trust it. After removing it, you'll need to go into the Ring app and then the Control Center > Authorized Clients > Remove All Devices. Then log back in and generate a new token.

Never post private information on the Internet.

shaileshck commented 3 years ago

Thanks for the update. I have edited the token and it’s not as it is being aware of the threat issue.

Hope in that case it should not be an issue.

Regards

Shailesh K.

On Mon, 19 Oct 2020 at 7:23 PM, SlasherKG notifications@github.com wrote:

@shaileshck https://github.com/shaileshck you need to remove that Ring token from your post quick. Someone can gain access to all your devices.

Actually, it's probably too late. After removing it, you'll need to go into the Ring app and then the Control Center > Authorized Clients > Remove All Devices. Then log back in and generate a new token.

Never post private information on the Internet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dgreif/ring/issues/469#issuecomment-712171828, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFLWWBZCJRFUD7YRMDQZ2TSLRAERANCNFSM4SEDNSSQ .

SlasherKG commented 3 years ago

Thanks for the update. I have edited the token and it’s not as it is being aware of the threat issue. Hope in that case it should not be an issue. Regards Shailesh K. … On Mon, 19 Oct 2020 at 7:23 PM, SlasherKG @.***> wrote: @shaileshck https://github.com/shaileshck you need to remove that Ring token from your post quick. Someone can gain access to all your devices. Actually, it's probably too late. After removing it, you'll need to go into the Ring app and then the Control Center > Authorized Clients > Remove All Devices. Then log back in and generate a new token. Never post private information on the Internet. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#469 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFLWWBZCJRFUD7YRMDQZ2TSLRAERANCNFSM4SEDNSSQ .

I would still strongly recommend following the steps I provided to revoke access, then just generate a new token afterward. Your token was posted on the Internet for over an hour, there's no telling who saw it and possible search engine caching as well.

But I suppose if you don't care that someone could potentially spy on you...

shaileshck commented 3 years ago

Thanks for the update. I have edited the token and it’s not as it is being aware of the threat issue. Hope in that case it should not be an issue. Regards Shailesh K. … On Mon, 19 Oct 2020 at 7:23 PM, SlasherKG @.***> wrote: @shaileshck https://github.com/shaileshck you need to remove that Ring token from your post quick. Someone can gain access to all your devices. Actually, it's probably too late. After removing it, you'll need to go into the Ring app and then the Control Center > Authorized Clients > Remove All Devices. Then log back in and generate a new token. Never post private information on the Internet. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#469 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFLWWBZCJRFUD7YRMDQZ2TSLRAERANCNFSM4SEDNSSQ .

I would still strongly recommend following the steps I provided to revoke access, then just generate a new token afterward. Your token was posted on the Internet for over an hour, there's no telling who saw it and possible search engine caching as well.

But I suppose if you don't care that someone could potentially spy on you...

Thanks as suggested. Edited the post and also followed process as suggested..

Regards

Shailesh K.

hipstersmoothie commented 3 years ago

@dgreif Would it be possible to create an option that create a second "virtual" doorbell for tvOS automation?

Context: I like seeing the motion on my Apple TV, but the chime is pretty annoying. A "virtual" doorbell that's only used for tvOS would solve this:

dgreif commented 3 years ago

@hipstersmoothie I can understand where you are coming from with this request, but this feature isn't something I want to invest any more time in. The simple fact is that Apple should be adding this feature to TvOS, rather than homebridge plugins hacking around their current limitations. I think it's a good feature for them to add, and I recommend you submit that feedback to them.