java.lang.IllegalArgumentException: Parameter declaration do should be a vector Edit

[juise]

I think that I fixed the bug in functions has multiple arity. Can you CR and test my code?

[dgrnbrg]

I am in the process of reviewing and merging this code. I have it fixed on my local machine, but I'm not seeing the changes I pushed to github on github itself.

[juise]

Hmm, I see you commits on github, looks lile it was be temporary problems on github after update.

[dgrnbrg]

I have committed a modified version of your fix that reports on which arities specifically aren't covered. Thank you for your help!

[juise]

Hi!

After test new code I got:

$ lein run -m guzheng.core guzheng.sample instrumenting guzheng/sample.clj in ns guzheng.sample: arity [] is not covered in "defn do-hello" on line 3 in ns guzheng.sample: arity [x] is not covered in "defn do-condp" on line 8 in ns guzheng.sample: arity [x] is not covered in "defn do-condp2" on line 15 in ns guzheng.sample: arity [x] is not covered in "defn do-cond" on line 21 in ns guzheng.sample: arity [] is not covered in "defn uncalled-for" on line 28 in ns guzheng.sample: arity [] is not covered in "defn defn-multi-arity" on line 30 in ns guzheng.sample: arity [x] is not covered in "defn defn-multi-arity" on line 30 in ns guzheng.sample: arity [x] is not covered in "fn [x]" on line 34 in ns guzheng.sample: arity [] is not covered in "fn ([] "hi")" on line 36 in ns guzheng.sample: arity [x] is not covered in "fn ([] "hi")" on line 36

But after test my code I got:

$ lein run -m guzheng.core guzheng.sample instrumenting guzheng/sample.clj in ns guzheng.sample: do-hello is not covered in "defn" on line 3 in ns guzheng.sample: do-condp is not covered in "defn" on line 8 in ns guzheng.sample: do-condp2 is not covered in "defn" on line 15 in ns guzheng.sample: do-cond is not covered in "defn" on line 21 in ns guzheng.sample: uncalled-for is not covered in "defn" on line 28 in ns guzheng.sample: defn-multi-arity is not covered in "defn" on line 30 in ns guzheng.sample: body is not covered in "fn" on line 34 in ns guzheng.sample: body is not covered in "fn" on line 36

[dgrnbrg]

I don't quite understand what you mean...

I have a test suite in lein-guzheng at https://github.com/dgrnbrg/lein-guzheng/blob/master/test/lein_guzheng/test/core.clj that tests guzheng on lein1 and lein2, with clojure.test and midje. That suite is passing according to how I expect it to work.

I changed the reporting for functions to report which arities of the functions aren't tested. I identify the arities by their arglists rather than the arity counts, since that seemed a bit more reasonable.

I wanted to be able to distinguish a totally uncovered function, a partially covered function, and a fully covered function.

Does that match your expectations?

On Thu, Sep 20, 2012 at 2:05 PM, Alexander Petrovsky < notifications@github.com> wrote:

Hi!

After test new code I got:

$ lein run -m guzheng.core guzheng.sample instrumenting guzheng/sample.clj in ns guzheng.sample: arity [] is not covered in "defn do-hello" on line 3 in ns guzheng.sample: arity [x] is not covered in "defn do-condp" on line 8 in ns guzheng.sample: arity [x] is not covered in "defn do-condp2" on line 15 in ns guzheng.sample: arity [x] is not covered in "defn do-cond" on line 21 in ns guzheng.sample: arity [] is not covered in "defn uncalled-for" on line 28 in ns guzheng.sample: arity [] is not covered in "defn defn-multi-arity" on line 30 in ns guzheng.sample: arity [x] is not covered in "defn defn-multi-arity" on line 30 in ns guzheng.sample: arity [x] is not covered in "fn [x]" on line 34 in ns guzheng.sample: arity [] is not covered in "fn ([] "hi")" on line 36 in ns guzheng.sample: arity [x] is not covered in "fn ([] "hi")" on line 36

But after test my code I got:

$ lein run -m guzheng.core guzheng.sample instrumenting guzheng/sample.clj in ns guzheng.sample: do-hello is not covered in "defn" on line 3 in ns guzheng.sample: do-condp is not covered in "defn" on line 8 in ns guzheng.sample: do-condp2 is not covered in "defn" on line 15 in ns guzheng.sample: do-cond is not covered in "defn" on line 21 in ns guzheng.sample: uncalled-for is not covered in "defn" on line 28 in ns guzheng.sample: defn-multi-arity is not covered in "defn" on line 30 in ns guzheng.sample: body is not covered in "fn" on line 34 in ns guzheng.sample: body is not covered in "fn" on line 36

— Reply to this email directly or view it on GitHubhttps://github.com/dgrnbrg/guzheng/pull/5#issuecomment-8740006.

[juise]

Sorry, it's my little mistake, you are right. Thank you for code

[juise]

Can you please mail me to my email askjuise@gmail.com. I have a couple questions for you.