search

dgrnbrg / spiral

Like Ring, but built for core.async
Eclipse Public License 1.0
125 stars 6 forks source link

support vertx? #12

Open cocodrino opened 9 years ago

cocodrino commented 9 years ago

Hello!..vertx has a small ring adapter, unfortunately this block and it doesnt take advantages of vertx, which is pretty bad considering than the main advantage for vertx is than it's async non blocking..would be really cool adapt spiral to vertx...

https://github.com/stream1984/ring-vertx-adapter

dgrnbrg commented 9 years ago

I think that's a great idea! Would you like to look into the feasibility of it?

cocodrino commented 9 years ago

Hi..sorry I'm not a clojure expert nor vertx, hopefully @tobias or @stream1984 can give you a better point of view.....

dgrnbrg commented 9 years ago

Does the ring vertx adapter support an async mode?

tobias commented 9 years ago

The vertx ring adapter is currently not async. After looking at spiral, I think a better approach is to borrow the pieces of the adapter that translate between a vertx request and ring request/response maps, and use those directly in a vertx-adapter for spiral. I don't do much with vertx anymore, but would be happy to guide anyone who wanted to take this on.

dgrnbrg commented 9 years ago

Likewise, I'd be happy to explain any necessary spiral internals.

On Wed, Apr 8, 2015 at 8:19 PM Toby Crawley notifications@github.com wrote:

The vertx ring adapter is currently not async. After looking at spiral, I think a better approach is to borrow the pieces of the adapter that translate between a vertx request and ring request/response maps, and use those directly in a vertx-adapter for spiral. I don't do much with vertx anymore, but would be happy to guide anyone who wanted to take this on.

— Reply to this email directly or view it on GitHub https://github.com/dgrnbrg/spiral/issues/12#issuecomment-91075844.