search

dgrnbrg / spiral

Like Ring, but built for core.async
Eclipse Public License 1.0
125 stars 6 forks source link

support Immutant #13

Closed tobias closed 9 years ago

tobias commented 9 years ago

Immutant 2.x has an async model that is similar to http-kit, so writing an adapter was straightforward. I have it sitting on a branch right now (https://github.com/tobias/spiral/tree/immutant-support), since it depends on changes that will be in the next release of Immutant (which should be this week). Once that's out, I'll update that branch and submit a PR (assuming you are interested in receiving it :) ). I also have a fix for route-concurrently that is needed for the tests to pass with Immutant (parked at https://github.com/tobias/spiral/commit/9e23fdeba7553e104930b2118bb1bef354702853) that I'll also submit as a PR at the same time.

dgrnbrg commented 9 years ago

Yes, I'm definitely interested in the PR! That fix looks good.

tobias commented 9 years ago

Great! I'll come back for a visit once we release.

dgrnbrg commented 9 years ago

I think we now have solid support for Immutant. Thanks @tobias!

tobias commented 9 years ago

My pleasure!

On Thu, Apr 16, 2015 at 3:56 PM, David Greenberg notifications@github.com wrote:

Closed #13 https://github.com/dgrnbrg/spiral/issues/13.

— Reply to this email directly or view it on GitHub https://github.com/dgrnbrg/spiral/issues/13#event-283384944.