search

dgrnbrg / vim-redl

A better Vim integration story for Clojure
106 stars 8 forks source link

Repl output on windows throws in carriage returns #7

Closed kotarak closed 10 years ago

kotarak commented 11 years ago

On Windows I get spurious carriage returns in the repl output.

redl-cr

dgrnbrg commented 11 years ago

Is that possible due to pprint? Or could it be a typo in the way I copied your repl implementation?

kotarak commented 11 years ago

I remember having issues with that with VC repl too. Let me check.

kotarak commented 11 years ago

I think I "fixed" it in showText. While you don't check for carriage returns in your show_text.

As you find from my comment: this change would do sometimes the wrong thing. (Removing legal carriage returns on Unix.) Maybe there should be check for Windows?

dgrnbrg commented 11 years ago

Do you know how to make that check? I'd be happy to implement it, if so. However, I don't have a copy of Windows to test on.

kotarak commented 11 years ago

There are the following features to test: win16 (can be ignored, I guess, just as the dos16 and dos32 versions), win32, win32unix and win64, cf. the feature list.

A test for any of those probably has to be self-rolled:

function isWindows()
    return has("win32") || has("win32unix") || has("win64")
endfunction
dgrnbrg commented 10 years ago

I just committed a fix for your issue. Sorry for taking so long!