search

dgrr / http2

HTTP/2 implementation for fasthttp
Apache License 2.0
208 stars 36 forks source link

Fix some edge cases #16

Closed AMekss closed 3 years ago

AMekss commented 3 years ago

This PR is related and closes this issue: https://github.com/dgrr/http2/issues/15

It fixes 2 edge cases:

  1. Server hangs when client sends empty data payload within POST or PUT request. According to the specs END_STREAM flag can be sent in headers if DATA will not follow.
  2. Server make client hang waiting on setting acknowledgement when client sends setting frames during "handshake" phase
AMekss commented 3 years ago

I'm also open to discuss and change my implementation.. still figuring out my way around h2 spec and this project :)

dgrr commented 3 years ago

That is right! I didn't saw the bw.Flush(). Thanks