search

dgrr / http2

HTTP/2 implementation for fasthttp
Apache License 2.0
208 stars 35 forks source link

Create internal dir instead of adding some deps. #36

Closed efectn closed 2 years ago

dgrr commented 2 years ago

Hello. Thanks for the PR... but why? What's the difference?

efectn commented 2 years ago

Hello. Thanks for the PR... but why? What's the difference?

Dependency graph won't be wide. Also managing little modules will be easy and stable like Fiber. But this changes don't so matter. Depends on your opinions.

dgrr commented 2 years ago

I prefer to be go mod the one managing everything. But, I'll leave this PR open, maybe in the future is useful, or someone can convince me why we need this.

Anyway, thanks for taking the time to do the PR, appreciate it!