search

dgrr / http2

HTTP/2 implementation for fasthttp
Apache License 2.0
208 stars 35 forks source link

Add test #50

Closed vecpeng closed 2 years ago

vecpeng commented 2 years ago

The test cover is only 15.5%.There is a long way to improve it. image

dgrr commented 2 years ago

Hello. This pull request includes the contents of the other, as far as I see. I'll take a look later on the RFC about the HPACK table, because I am not sure if we need an uint32.

vecpeng commented 2 years ago

@dgrr , thanks for your review. I find that the implementation of Go also use uint32 instead of int. https://github.com/bradfitz/http2/blob/master/hpack/hpack.go#L45.

dgrr commented 2 years ago

@dgrr , thanks for your review. I find that the implementation of Go also use uint32 instead of int. https://github.com/bradfitz/http2/blob/master/hpack/hpack.go#L45.

It's fine. I guess it's because the table size can only be a positive number.

vecpeng commented 2 years ago

@dgrr, Sorry, it seems that workflow fails because some lint problems.And now it is fixed.

dgrr commented 2 years ago

Thanks for your pull request!