search

dgrr / http2

HTTP/2 implementation for fasthttp
Apache License 2.0
208 stars 35 forks source link

WARNING: DATA RACE #69

Open zishang520 opened 1 month ago

zishang520 commented 1 month ago 
==================
WARNING: DATA RACE
Read at 0x00c0002ea130 by goroutine 23:
  github.com/dgrr/http2.(*serverConn).sendPingAndSchedule()
      C:/Users/test/go/pkg/mod/github.com/dgrr/http2@v0.3.6-0.20231023141632-12370d352f5f/serverConn.go:979 +0x3c
  github.com/dgrr/http2.(*serverConn).sendPingAndSchedule-fm()
      <autogenerated>:1 +0x33

Previous write at 0x00c0002ea130 by goroutine 14:
  github.com/dgrr/http2.(*serverConn).writeLoop()
      C:/Users/test/go/pkg/mod/github.com/dgrr/http2@v0.3.6-0.20231023141632-12370d352f5f/serverConn.go:984 +0x128
  github.com/dgrr/http2.(*serverConn).Serve.func2()
      C:/Users/test/go/pkg/mod/github.com/dgrr/http2@v0.3.6-0.20231023141632-12370d352f5f/serverConn.go:114 +0x76

Goroutine 23 (running) created at:
  time.goFunc()
      D:/Language/Go/src/time/sleep.go:177 +0x44

Goroutine 14 (running) created at:
  github.com/dgrr/http2.(*serverConn).Serve()
      C:/Users/test/go/pkg/mod/github.com/dgrr/http2@v0.3.6-0.20231023141632-12370d352f5f/serverConn.go:108 +0x393
  github.com/dgrr/http2.(*Server).ServeConn()
      C:/Users/test/go/pkg/mod/github.com/dgrr/http2@v0.3.6-0.20231023141632-12370d352f5f/server.go:87 +0xe69
  github.com/dgrr/http2.(*Server).ServeConn-fm()
      <autogenerated>:1 +0x47
  github.com/valyala/fasthttp.(*Server).serveConn()
      C:/Users/test/go/pkg/mod/github.com/valyala/fasthttp@v1.52.0/server.go:2135 +0x4e5
  github.com/valyala/fasthttp.(*Server).serveConn-fm()
      <autogenerated>:1 +0x47
  github.com/valyala/fasthttp.(*workerPool).workerFunc()
      C:/Users/test/go/pkg/mod/github.com/valyala/fasthttp@v1.52.0/workerpool.go:224 +0xe1
  github.com/valyala/fasthttp.(*workerPool).getCh.func1()
      C:/Users/test/go/pkg/mod/github.com/valyala/fasthttp@v1.52.0/workerpool.go:196 +0x4a
==================
dgrr commented 1 month ago

Yes, I won't actively look into it but I'll accept a PR