search

dgrr / http2

HTTP/2 implementation for fasthttp
Apache License 2.0
208 stars 36 forks source link

Support PUSH_PROMISE? #7

Closed dgrr closed 2 years ago

dgrr commented 3 years ago

I'd be nice if routers or framework implementations like gramework or fiber could choose to push some content before being asked to. Think about the possible implementation.

zMrKrabz commented 3 years ago

There was a rejected pull request here, that I added to my fhttp library, which is a fork of net/http.

dgrr commented 3 years ago

Hello. Thanks for the info. Why it was rejected? I see no apparent reason

zMrKrabz commented 3 years ago

Think it is because Chrome was the only browser that supported ENABLE_PUSH, but is removing it in the near future

dgrr commented 3 years ago

The implementation is quite difficult for frameworks in fasthttp or even net/http, so I can understand is not fully supported. I will not support it for now, but I'll leave the issue open in case someone has a suggestion

dgrr commented 2 years ago

Yep, it won't support PUSH_PROMISE so far