search

dgrtwo / tidy-text-mining

Manuscript of the book "Tidy Text Mining with R" by Julia Silge and David Robinson
http://tidytextmining.com
Other
1.31k stars 806 forks source link

update url in YAML of index.Rmd #55

Closed apreshill closed 5 years ago

apreshill commented 5 years ago

Hi Julia & Dave,

I am diving deep into bookdown for the Advanced R Markdown workshop at the upcoming rstudio::conf, and plugged your book's site into the online twitter card validator:

https://cards-dev.twitter.com/validator

screen shot 2018-12-20 at 4 30 05 pm

There is no image! But you have the cover-image specified, so I think what is missing is the url. Copied format from here.

Contrast with:

screen shot 2018-12-20 at 4 35 06 pm

I hope this works! At the very least, it should do no harm 😇

juliasilge commented 5 years ago

Let's give this a go!

juliasilge commented 5 years ago

Still no luck on the Twitter card. 😕

I just tried it on the validator after Travis built from your PR.

apreshill commented 5 years ago

Oh but I am close! It is there now in the metadata tags:

<meta property="og:image" content="https://www.tidytextmining.comimages/cover.png">
<meta name="twitter:image" content="https://www.tidytextmining.comimages/cover.png">

I forgot the slash at the end of the url! Will return :)

apreshill commented 5 years ago

I think it should work- I just tried it over on my stat545 repo and was successful!

https://github.com/apreshill/stat545-reboot/blob/test-travis/index.Rmd

screen shot 2018-12-20 at 7 58 12 pm
apreshill commented 5 years ago

🎉

screen shot 2018-12-20 at 8 04 01 pm
juliasilge commented 5 years ago

✨ Hooray! ✨

Thanks so much for your help on this.