search

dgrubelic / vue-authenticate

Simple Vue.js authentication library
1.43k stars 252 forks source link

Allow for non-pop login screen #240

Open ajmas opened 2 years ago

ajmas commented 2 years ago

Based on what I see in options.js and playing around with the display option, it does not current seem to be possible to force a non-pop-up authentication flow. This can be an issue for flows where a pop-up is not suitable.

ajmas commented 2 years ago

Since we lose the logic around the pop-up, maybe having an option to store state in session storage and then on page load have a continueAuth() call, which behind the scenes:

Maybe there is another approach?

tomastan commented 4 months ago

Agree. We have issues integrating this lib if the app is shown in restricted webview of a mobile app for example

@ajmas how did you resolve that back then?

ajmas commented 3 months ago

@tomastan I ended up forking the project, but I'll need to look at my code to remind myself.

ajmas commented 3 months ago

@tomastan I just looked through the code and right now there isn't an alternative to the popup. Looks like some code rework is needed to provide that possibility. I'll create a ticket for this.

tomastan commented 3 months ago

@tomastan I just looked through the code and right now there isn't an alternative to the popup. Looks like some code rework is needed to provide that possibility. I'll create a ticket for this.

Let me follow your fork then ;) Unfortunately as I understand it is Vue 3 only, while our codebase is not yet migrated. Plus if you said, popupless flow is not there, so likely we need to look for a temporary workaround.

ajmas commented 3 months ago

It is Vue 3 only. I made the choice because of our own project requirements and I couldn’t work out how to make it support both.