Fix Fingerprint64 to match reference implementation

dgryski / go-farm

go-farm: a pure-Go farmhash implementation

MIT License

245 stars 22 forks source link

Fix Fingerprint64 to match reference implementation #7

Closed nicolaasuni closed 7 years ago

nicolaasuni commented 7 years ago

The Fingerprint64 function now matches the C++ Google's implementation of the FarmHash code that uses the farmhashna::Hash64 : https://github.com/google/farmhash/blob/master/src/farmhash.cc#L1963
The naHash64 function has been extended to be able to process strings longer than 64 bytes.
The tests for Fingerprint64 have been updated to ensure the same results as the C++ implementation.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling c74737826395052396ba26c35a5c340bf282c834 on fingerprintfix into e2d0fe22b456fa0a35cd883ba355ecfcf1881490 on master.

nicolaasuni commented 7 years ago

Yes, the previous implementation was generating wrong results for naHash64 with strings longer than 64 bytes.