search

dgryski / go-tsz

Time series compression algorithm from Facebook's Gorilla paper
BSD 2-Clause "Simplified" License
538 stars 67 forks source link

Use uint64 type for timestamps #23

Closed tsenart closed 6 years ago

tsenart commented 6 years ago

This commit changes the numeric type of the timestamps from uint32 to uint64 as described in the paper.

As this is a breaking change, I'd recommend we introduce semantic versioning in this library.

For context, this change is a prerequisite for me to adopt this library in Vegeta for use in the plot command that ought to handle larger data sets gracefully.

tsenart commented 6 years ago

Just found out this isn't working as it stands.

tsenart commented 6 years ago

Yeah, I don't have the time to figure this out currently. I'll encode durations as milliseconds for now which should be OK for must use cases with an uint32.