dgryski / semgrep-go

Go rules for semgrep and go-ruleguard
MIT License
457 stars 37 forks source link

fix: Use unique ID for return-nil-err #55

Closed theoretick closed 1 year ago

theoretick commented 1 year ago

nilerr.yml uses the same rule ID as returnnil.yml which can cause race conditions when both are included together.

There is some overlap in the two rules that may be worth re-evaluating but the simplest fix to prevent these race conditions is assigning unique IDs for each

dgryski commented 1 year ago

Thanks!