search

dgryski / tinygo-test-corpus

run a test corpus against tinygo
MIT License
4 stars 1 forks source link

add terminate functionality. Resolves #11 #12

Closed soypat closed 2 years ago

soypat commented 2 years ago

Let me know what you think of this methodology.

dgryski commented 2 years ago

The problem is that log.Fatalf terminates the process and defers won't run.

soypat commented 2 years ago

Alright, here's a take using log.Panic, which seems to be the way forward without adding too much error handling code.

soypat commented 2 years ago

Solved the merge conflict, PTAL

dgryski commented 2 years ago

I wonder if we could build on this and instead of panic return an error via the control channel? I'd need to think about this a bit more..