Update requires in explode namespace

dgsuarez / reruby

Refactor Ruby

MIT License

35 stars 2 forks source link

Update requires in explode namespace #16

Closed dgsuarez closed 6 years ago

dgsuarez commented 7 years ago

Explode creates new files, but never requires them. There are 2 approaches that can be taken:

Add the requires for the new files in the original one.
Search for requires for the original, and add after each of those the requires for the new files.

dcarral commented 6 years ago

@dgsuarez I'm wondering if you have any thoughts on the convenience on one versus the other approach, on top of my head:

Taking into account the use case where a single file is used to require all the files within a gem, we probably would want to go for the second approach. It would also protect against the removal of that concrete file potentially exploding the test suite.

What do you think?

dgsuarez commented 6 years ago

Yeah, I like the 2nd one better as well, it's what I'd expect the tool to do.